Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check path for being accessible when the storage is a object home #12627

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Only check path for being accessible when the storage is a object home #12627

merged 1 commit into from
Jul 2, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jul 2, 2024

Forward-ported nextcloud/server#24103

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@mejo-
fix(sharing): Only check path for being accessible when the storage i…
11a5a6d 
…s a object home

Forward-ported nextcloud/server#24103

Signed-off-by: Jonas <jonas@freesources.org>

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/groupfolder-share-object-storage branch from 95fb4cc to 11a5a6d Compare July 2, 2024 08:52
@mejo-
Copy link
Member Author

mejo- commented Jul 2, 2024

We stumbled upon this in Deck, where sharing files from groupfolders on object storage was broken for a customer.

@mejo-
Copy link
Member Author

mejo- commented Jul 2, 2024

Related Deck PR: nextcloud/deck#6062

@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Jul 2, 2024
@nickvergessen nickvergessen added feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Jul 2, 2024
@nickvergessen
Copy link
Member

/backport to stable29

@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen nickvergessen merged commit 82bf80c into main Jul 2, 2024
63 checks passed
@nickvergessen nickvergessen deleted the fix/groupfolder-share-object-storage branch July 2, 2024 09:21
This was referenced Jul 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mejo- @nickvergessen @juliusknorr